Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add 1.29.2 binary to cache #4100

Merged
merged 2 commits into from
Feb 26, 2024
Merged

chore: add 1.29.2 binary to cache #4100

merged 2 commits into from
Feb 26, 2024

Conversation

gaopenghigh
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add 1.29.2 binaries into cache.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Feb 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8043329991

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.39%
Totals Coverage Status
Change from base Build 8042991230: 0.0%
Covered Lines: 2292
Relevant Lines: 2887
💛 - Coveralls

AbelHu
AbelHu approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@AbelHu AbelHu added the VHD your change will be included in the following VHDs label Feb 23, 2024
@gaopenghigh gaopenghigh merged commit 23ecd1e into master Feb 26, 2024
26 checks passed
@gaopenghigh gaopenghigh deleted the gaopeng/1.29.2 branch February 26, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbelHu AbelHu AbelHu approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@ShiqianTao ShiqianTao Awaiting requested review from ShiqianTao

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

Assignees
No one assigned
Labels
VHD your change will be included in the following VHDs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaopenghigh @coveralls @AbelHu