Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support cse log for windows #3944

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

junjiezhang1997
Copy link
Collaborator

@junjiezhang1997 junjiezhang1997 commented Jan 3, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Support cse log for windows.
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Jan 3, 2024

Pull Request Test Coverage Report for Build 7566063722

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.313%

Totals Coverage Status
Change from base Build 7551707272: 0.0%
Covered Lines: 2285
Relevant Lines: 2881

💛 - Coveralls

@junjiezhang1997 junjiezhang1997 force-pushed the junjiezhang/support-cse-log-for-windows branch from 7eb1dee to 645bbc9 Compare January 5, 2024 08:37
@junjiezhang1997 junjiezhang1997 force-pushed the junjiezhang/support-cse-log-for-windows branch from 645bbc9 to ef34e4e Compare January 5, 2024 15:17
@junjiezhang1997 junjiezhang1997 force-pushed the junjiezhang/support-cse-log-for-windows branch from ef34e4e to 39a45a5 Compare January 5, 2024 16:24
@junjiezhang1997 junjiezhang1997 force-pushed the junjiezhang/support-cse-log-for-windows branch from 20eb921 to 98f5402 Compare January 8, 2024 02:59
@junjiezhang1997 junjiezhang1997 force-pushed the junjiezhang/support-cse-log-for-windows branch from 98f5402 to 3536228 Compare January 8, 2024 03:05
Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@junjiezhang1997 junjiezhang1997 merged commit 021c6a0 into master Feb 20, 2024
32 checks passed
@junjiezhang1997 junjiezhang1997 deleted the junjiezhang/support-cse-log-for-windows branch February 20, 2024 12:29
@junjiezhang1997 junjiezhang1997 added the windows cse package The change with this label needs to build a new AKS Windows CSE Scripts Package. label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows cse package The change with this label needs to build a new AKS Windows CSE Scripts Package. windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants