Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache and use Linux private packages for kubctl and kubelet. #3939

Merged
merged 10 commits into from
Jan 11, 2024

Conversation

daxakp
Copy link
Contributor

@daxakp daxakp commented Dec 26, 2023

What type of PR is this?
feature

What this PR does / why we need it:
This PR downloads and saves private packages for kubelet and kubectl. This packages will be used at run-time when needed.
The PR adds two build-time variables as below:

Build Variables:

name: PRIVATE_PACKAGES_URL
value: comma separated list of packages, for example: https://private-acs-mirror.azureedge.net/kubernetes/v1.25.6-hotfix.20230612/binaries/kubernetes-node-linux-amd64.tar.gz,https://private-acs-mirror.azureedge.net/kubernetes/v1.28.0/binaries/kubernetes-node-linux-amd64.tar.gz

name: AZURE_MSI_RESOURCE_ID
value: MSI resource ID that is created already and has sufficient roles assigned to be able to access the above private packages from the packer VM.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Dec 26, 2023

Pull Request Test Coverage Report for Build 7484217224

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 79.356%

Totals Coverage Status
Change from base Build 7483530675: 0.02%
Covered Lines: 2291
Relevant Lines: 2887

💛 - Coveralls

@daxakp daxakp changed the title Cache and use Linux private packages for kube-proxy, kubctl and kubelet. feat: cache and use Linux private packages for kube-proxy, kubctl and kubelet. Dec 26, 2023
@daxakp daxakp force-pushed the daxapatel/linux-private-packages branch from a369fc1 to 0e1a3f0 Compare December 27, 2023 00:56
@daxakp daxakp force-pushed the daxapatel/linux-private-packages branch from 0e1a3f0 to d1a3d61 Compare December 28, 2023 20:28
@daxakp daxakp force-pushed the daxapatel/linux-private-packages branch from aeea657 to c38fca3 Compare January 8, 2024 19:59
@ganeshkumarashok
Copy link
Contributor

ganeshkumarashok commented Jan 8, 2024

would it be useful to do validation of the private package URLs?

Copy link

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the karpenter side, shouldn't be any breaking changes since the url passed in is an optional parameter and functions fine when we pass in an empty string.

Please wait on node sig approval as well before merging :)

@daxakp daxakp enabled auto-merge (squash) January 11, 2024 01:00
@daxakp daxakp force-pushed the daxapatel/linux-private-packages branch from bdce654 to be12339 Compare January 11, 2024 02:43
@daxakp daxakp merged commit c7f5571 into master Jan 11, 2024
32 of 38 checks passed
@daxakp daxakp deleted the daxapatel/linux-private-packages branch January 11, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants