-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cache and use Linux private packages for kubctl and kubelet. #3939
Conversation
e2d98cd
to
a369fc1
Compare
Pull Request Test Coverage Report for Build 7484217224
💛 - Coveralls |
a369fc1
to
0e1a3f0
Compare
0e1a3f0
to
d1a3d61
Compare
aeea657
to
c38fca3
Compare
would it be useful to do validation of the private package URLs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on the karpenter side, shouldn't be any breaking changes since the url passed in is an optional parameter and functions fine when we pass in an empty string.
Please wait on node sig approval as well before merging :)
bdce654
to
be12339
Compare
What type of PR is this?
feature
What this PR does / why we need it:
This PR downloads and saves private packages for kubelet and kubectl. This packages will be used at run-time when needed.
The PR adds two build-time variables as below:
Build Variables:
At run-time, given a Kube version, the cached version if exists is used by default.
For example,
kubernetes package from https://private-acs-mirror.azureedge.net/kubernetes/v1.28.0/binaries/kubernetes-node-linux-amd64.tar.gz is saved as /opt/kubernetes/downloads/private-packages/v1.28.0.tar.gz
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: