Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azure-cni and azure-ipam installer images #3850

Closed
wants to merge 1 commit into from

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Nov 22, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it: Adds azure-cni and azure-ipam images, which are replacing cni-dropgz as the recommended way to deploy the CNI binaries

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Nov 22, 2023

Pull Request Test Coverage Report for Build 7034863928

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.095%

Totals Coverage Status
Change from base Build 7032137050: 0.0%
Covered Lines: 2255
Relevant Lines: 2851

💛 - Coveralls

@@ -100,6 +100,8 @@ $global:imagesToPull += @(
"mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.28.0", # for k8s 1.28.x
# OMS-Agent (Azure monitor). Owner: ganga1980 (Ganga Mahesh Siddem)
"mcr.microsoft.com/azuremonitor/containerinsights/ciprod:win-3.1.15",
# Azure CNI. Owner: rbtr (Evan Baker)
"mcr.microsoft.com/containernetworking/azure-cni:v1.5.15",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between this cni version and the legacy azure cni?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a change to the azure-cni itself, it is a new way of packaging it - we want to deliver it consistently in all scenarios via this container

@rbtr rbtr closed this Dec 18, 2023
auto-merge was automatically disabled December 18, 2023 18:12

Pull request was closed

@rbtr rbtr force-pushed the chore/cni-installers branch from 9600533 to 7c18f82 Compare December 18, 2023 18:12
@rbtr
Copy link
Contributor Author

rbtr commented Apr 10, 2024

forgot about this one and opened a new PR for this #4256

@rbtr rbtr deleted the chore/cni-installers branch April 10, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants