revert, add comment

Azure · Feb 13, 2025 · b0ed29e · b0ed29e
1 parent c3fa378
commit b0ed29e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/parts/common/components.json b/parts/common/components.json
@@ -28,8 +28,9 @@
       "multiArchVersionsV2": [],
       "windowsVersions": [
         {
+          "comment": "1809 gets patches every 6 months or so. The alternative is ltsc2019 which gets patches every couple of years. Most customers use 1809, so we keep that on the VHD",
           "renovateTag": "registry=https://mcr.microsoft.com, name=windows/nanoserver",
-          "latestVersion": "ltsc2019",
+          "latestVersion": "1809",
           "windowsSkuMatch": "2019-containerd"
         },
         {

diff --git a/schemas/components.cue b/schemas/components.cue
@@ -23,6 +23,7 @@ package components
 }
 
 #WindowsVersion: {
+	comment?:                string
 	k8sVersion?:             string
 	renovateTag?:            string
 	latestVersion:           string

diff --git a/vhdbuilder/packer/windows/components_json_helpers.tests.ps1 b/vhdbuilder/packer/windows/components_json_helpers.tests.ps1
@@ -645,9 +645,9 @@ Describe 'Tests of components.json ' {
 
         $components.Length | Should -BeGreaterThan 0
 
-        # Pause image shouldn't change too often, so let's check that is in there.
+        # core images shouldn't change too often, so let's check that is in there.
         $components | Should -Contain "mcr.microsoft.com/windows/servercore:ltsc2019"
-        $components | Should -Contain "mcr.microsoft.com/windows/nanoserver:ltsc2019"
+        $components | Should -Contain "mcr.microsoft.com/windows/nanoserver:1809"
     }
 
     It 'has specific WS2022 containers' {