Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: pass the request ID to Clusters Service #1185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simonpasquier
Copy link
Collaborator

What this PR does

This change injects the request ID generated by the RP frontend into all requests made to the CS API.

Jira: https://issues.redhat.com/browse/ARO-14904
Link to demo recording:

Special notes for your reviewer

Copy link
Collaborator

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it maybe make sense to use the trace baggage here to?

After #1180 it should be available.

frontend/pkg/frontend/ocm_test.go Outdated Show resolved Hide resolved
@simonpasquier
Copy link
Collaborator Author

Does it maybe make sense to use the trace baggage here to?

you mean read the request ID from the trace baggage?

This change injects the request ID generated by the RP frontend into all
requests made to the CS API.

Jira: https://issues.redhat.com/browse/ARO-14904

Signed-off-by: Simon Pasquier <[email protected]>
@frzifus
Copy link
Collaborator

frzifus commented Jan 31, 2025

you mean read the request ID from the trace baggage?

yes :)

@simonpasquier
Copy link
Collaborator Author

cc @mbarnes @SudoBrendan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants