frontend: set default otel resource attributes #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
requested review from
bennerv,
mbarnes,
SudoBrendan,
mociarain,
venkateshsredhat,
Nanyte25 and
kostola
as code owners
frzifus
force-pushed
the
resource_attributes
branch
from
9f9d20f to
87289bc
Compare
mbarnes
requested changes
Jan 31, 2025
frontend/pkg/info/version.go
Outdated
| } | ||
|
|
||
| return version | ||
| } |
There was a problem hiding this comment.
This and /frontend/pkg/config are both single-function packages. Could we merge them?
Feel free to rename the merged package to something appropriate, like maybe util? (you pick)
There was a problem hiding this comment.
merged both into into a util package 👍
Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
resource_attributes
branch
from
87289bc to
63cd81f
Compare
Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
resource_attributes
branch
from
63cd81f to
9c1ea65
Compare
mbarnes
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Jira: https://issues.redhat.com/browse/ARO-14935
Link to demo recording:
Special notes for your reviewer
This change will add a default service name and version key similar like on OCM Cluster Service.
e.g. previous default:
cc @dinhxuanvu