Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update allowed location for openai resource #218

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

hund030
Copy link
Contributor

@hund030 hund030 commented Oct 28, 2024

Purpose

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
azd up
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@pamelafox
Copy link
Collaborator

Nice! However, that isn't all locations, just all the locations supported by GlobalStandard. I believe Azure itself supports more locations, right? So I'd suggest changing list to the full list thats in this table:
https://learn.microsoft.com/en-us/azure/ai-services/openai/concepts/models?tabs=python-secure%2Cglobal-standard%2Cstandard-chat-completions#global-standard-model-availability

@hund030
Copy link
Contributor Author

hund030 commented Oct 30, 2024

@pamelafox Yes, you are right! Updated.
Thanks for the suggestion!

@hund030 hund030 changed the title Allow deploying openai to any location Update allowed location for openai resource Oct 30, 2024
@pamelafox
Copy link
Collaborator

Thanks! Merging.

@pamelafox pamelafox merged commit baa3a78 into main Oct 30, 2024
5 checks passed
@pamelafox pamelafox deleted the zhihuan/remove_allowed_location branch October 30, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants