Update devcontainer with java and non-root user #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@StromFLIX and @cpeeyush: Given you submitted PRs over a year ago, I wanted to include you in the review request. We did a few more updates given CVE vulnerabilities, but your changes/suggestions should be represented in the PR updates. We welcome any feedback from you. |
ydaponte
requested changes
Nov 4, 2024
e2e_samples/parking_sensors_synapse/.devcontainer/devcontainer.json
Outdated
Show resolved
Hide resolved
| }, | ||
| "remoteUser": "mdwuser", | ||
| "postCreateCommand": "./.devcontainer/post_create.sh" |
There was a problem hiding this comment.
While testing and I get to the post_create.sh command I get the following error:
postCreateCommandfailed with exit code 127. Skipping any further user-provided commands.
Did you also have this problem? Maybe is just a problem on my side, but I would like to confirm with you.
Co-authored-by: Yennifer Santos <[email protected]>
…les/modern-data-warehouse-dataops into brsherwi/devcontainer
ydaponte
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Purpose
Fix issue #644 - Devcontainer failing with unsupported JDK
Fix issue #646 - Devcontainer changes file ownership in linux/wsl
Updates devcontainer to bring Critical and High CVE vulnerabilities reported to zero
Does this introduce a breaking change? If yes, details on what can break
No
Validation steps
java -versiontouch test.file/mnt/.../e2e_samples/parking_sensors(replace "..." with location where you cloned the code)Issues Closed or Referenced