Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data contextualization using sql graph to single_tech_samples #619

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Add data contextualization using sql graph to single_tech_samples #619

merged 9 commits into from
Nov 12, 2024

Conversation

cchenshu
Copy link
Contributor

@cchenshu cchenshu commented Feb 14, 2023 •
edited
Loading

Type of PR

  • Add a new sample to single_tech_samples/databricks

Purpose

  • This sample demonstrates how to contextualize data by looking up the relevant context from a graph model in Azure SQL Database.

@promisinganuj
Copy link
Contributor

@cchenshu Can we have DataContextualizationSolution.md merged to README.md? Also, I would suggest to make DataContextualizationSolution.md a lot lighter as we have already added most the information into playbook. For this sample, we can just keep the details which are really relevant.

promisinganuj
promisinganuj previously requested changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@promisinganuj promisinganuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes.

single_tech_samples/databricks/sample5_data_contextualization_sql_graph/README.md Outdated Show resolved Hide resolved
single_tech_samples/databricks/sample5_data_contextualization_sql_graph/README.md Outdated Show resolved Hide resolved
single_tech_samples/databricks/sample5_data_contextualization_sql_graph/README.md Outdated Show resolved Hide resolved
...tech_samples/databricks/sample5_data_contextualization_sql_graph/src/notebooks/demo-setup.py Outdated Show resolved Hide resolved
@promisinganuj
Copy link
Contributor

@gary918 , @cchenshu , now that we have published the blog, we can go ahead with this sample.
I will review it this week.

@devlace
Copy link
Contributor

devlace commented Oct 29, 2024

To be retired

@promisinganuj promisinganuj requested review from promisinganuj and devlace and removed request for promisinganuj and gary918 November 6, 2024 06:02
@promisinganuj promisinganuj dismissed their stale review November 6, 2024 06:09

not applicable anymore

@promisinganuj promisinganuj removed their request for review November 6, 2024 06:09
@promisinganuj
Copy link
Contributor

Hi @devlace , instead of deleting the whole changes, I have moved this sample to archive folder. Please have a look, we would need to merge it by bypassing branch protections.

@promisinganuj promisinganuj merged commit 0487920 into main Nov 12, 2024
3 of 4 checks passed
@promisinganuj promisinganuj deleted the feat/single_tech/data_contextualization branch November 12, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlace devlace devlace approved these changes

@promisinganuj promisinganuj promisinganuj left review comments

Assignees

@promisinganuj promisinganuj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cchenshu @promisinganuj @devlace