chore: refactor and add new types in connection with payments scenario #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganialhamad
requested review from
anfibiacreativa,
manekinekko and
sinedied
as code owners
anfibiacreativa
changed the title
|
Thank you @gm-al for sending these changes. We'll review them asap and keep you posted. |
|
@gm-al after chatting with the team, it looks like this PR introduced changes that are out of scope of the initial issue. Would you mind keeping only the Stripe enum types and revert all other changes? enum ReservationStatus {
Pending = "pending",
Active = "active",
Cancelled = "cancelled" ,
Archived = "archived"
}; |
|
Thank you @manekinekko for the update. Sure, I will look at this PR soon and revert the extra changes. |
|
hey @manekinekko sorry for the delay. I updated the PR, let me know if there is something else i need to adjust. |
manekinekko
requested changes
May 29, 2024
| @@ -10,7 +10,7 @@ export interface Reservation { | |||
| to: Date; | |||
| status: "pending" | "active" | "cancelled" | "archived"; | |||
There was a problem hiding this comment.
Suggested change
| status: "pending" | "active" | "cancelled" | "archived"; | |
| status: ReservationStatus; |
There was a problem hiding this comment.
Can you please add this import to this file:
import { ReservationStatus } from "./reservation-status";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR for #117—issue: #124. I did expand a little on the scope of this PR by moving the interfaces from the model folder to a separate folder so imports can be from a common source.