Updating sample code to use latest API versions #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only updated C# in previous PR. Updating other programming languages in this PR to Speech REST API version to 3.1 and ConversationAnalysis API version to 2022-10-01-preview.
|
@trrwilson and @BrianMouncer for review. |
BrianMouncer
approved these changes
Feb 10, 2023
| CONVERSATION_ANALYSIS_QUERY = "?api-version=2022-05-15-preview"; | ||
| CONVERSATION_SUMMARY_MODEL_VERSION = "2022-05-15-preview"; | ||
| CONVERSATION_ANALYSIS_QUERY = "?api-version=2022-10-01-preview"; | ||
| CONVERSATION_SUMMARY_MODEL_VERSION = "latest"; |
There was a problem hiding this comment.
what is the point of using latest, when CONVERSATION_ANALYSIS_QUERY and SPEECH_TRANSCRIPTION_PATH are static.
e.g. when v3.2 comes out, these existing clients will start using the new model version, but the old path and query, is that what you want to happen, or will that just make this more likely to break in the future?
There was a problem hiding this comment.
This change was provided by the Language team. It is likely that the Conversation Summary model version is updated frequently even when the API path remains the same, which would be hard to keep track of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Pull Request Type
What kind of change does this Pull Request introduce?