Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support rbac auth type in conversation_logger #1627

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leonavevor
Copy link
Contributor

@leonavevor leonavevor commented Jan 14, 2025

Purpose

  • To support rbac when conversation history is being saved

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Run it in devcontainer to test
git clone [[repo-address]](https://github.com/leonavevor/chat-with-your-data-solution-accelerator)
cd chat-with-your-data-solution-accelerator
git checkout main
  • Test the code
code/tests/utilities/helpers/test_azure_search_helper.py => test_get_conversation_logger_rbac()

What to Check

Verify that the following are valid

  • should be able to have your conversations saved even if you are not using key based auth (i.e using RBAC).

Other Information

@leonavevor
Copy link
Contributor Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant