feat: Automation flow for one click deployment #1290
Conversation
Coverage Report •
|
Prashant-Microsoft
requested review from
Roopan-Microsoft and
Prajwal-Microsoft
| az deployment sub create \ | ||
| --name automation-CWYD \ | ||
| --location eastus \ | ||
| --template-file infra/main.bicep \ |
There was a problem hiding this comment.
If this is to test the one click deploy button then I think this should use the infra/main.json file instead of the bicep file.
There was a problem hiding this comment.
There are basically two ways:
- we can use directly bicep files to deploy the resource
- or else first we need to generate arm template (nothing but main.json file) from bicep file. after it we can deploy the resources.
So, we are using step 1, instead of creating arm templates, directly using bicep file
Is there any specific reason that you are asking to use main.json file instead of bicep module? Please let us know.
| --name automation-CWYD \ | ||
| --location eastus \ | ||
| --template-file infra/main.bicep \ | ||
| --parameters environmentName=pslautomationtest location=eastus2 |
There was a problem hiding this comment.
Should there also be a step to tear this down and clean up the resources?
There was a problem hiding this comment.
yes, we are implementing that also.
|
|
||
| - name: Login to Azure | ||
| run: | | ||
| az login --service-principal -u ${{ secrets.AUTO_AZURE_CLIENT_ID }} -p ${{ secrets.AUTO_AZURE_CLIENT_SECRET }} --tenant ${{ secrets.AUTO_AZURE_TENANT_ID }} |
There was a problem hiding this comment.
We've created new variables AUTO_ - and not re-using the existing ones - we should update the existing github variables to your new subscription values and use them. At the moment, this strikes me as making things more complicated
There was a problem hiding this comment.
For testing purposes, we have created these variables so that they won't affect the current deployment. In the end, we will be using the same variables.
There was a problem hiding this comment.
The current deployment is not working as the spn has expired - you are free to re-use those variables if you like
|
hi there - can you help me understand what this PR is trying to do? What is the end goal? There is a ci.yml workflow which calls |
|
I've just looked into this and the credentials used to deploy have expired. I feel that it is best that you enter your credentials into the existing GH actions variables and get the build working again |
|
I feel that you have fixed the current build and that it is deploying to your subscription and destroying on every push to |
Purpose
Automation for one click deployment and cleanup the resources
Does this introduce a breaking change?
How to Test