Add sample for DLQ consumption of Service Bus Queue using Spring JMS #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...cebus-jms-dlq-queue/src/main/java/com/azure/spring/sample/jms/queue/QueueSendController.java
Fixed
Show fixed
Hide fixed
saragluna
reviewed
Jan 24, 2025
| private static final String DEAD_LETTER_QUEUE_NAME = QUEUE_NAME + DEAD_LETTER_QUEUE_NAME_SUFFIX; | ||
|
|
||
| @JmsListener(destination = QUEUE_NAME, containerFactory = "jmsListenerContainerFactory") | ||
| public void receiveMessage(JmsObjectMessage message) throws JMSException { |
There was a problem hiding this comment.
something we could improve here is using a message converter, and then serialize and deserialize the message.
There was a problem hiding this comment.
but we don't necessarily need to do it in this PR
...-queue/src/main/java/com/azure/spring/sample/jms/queue/ServiceBusJMSDLQQueueApplication.java
Outdated
Show resolved
Hide resolved
…s-jms-dlq-queue/src/main/java/com/azure/spring/sample/jms/queue/ServiceBusJMSDLQQueueApplication.java Co-authored-by: Xiaolu Dai <[email protected]>
saragluna
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Sample for DLQ consumption of Service Bus Queue using Spring JMS
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Follow the sample readme.
What to Check
N/A
Other Information
N/A