Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize search query generation #652

Merged
merged 11 commits into from
Sep 21, 2023
Merged

Stabilize search query generation #652

merged 11 commits into from
Sep 21, 2023

Conversation

srbalakr
Copy link
Collaborator

@srbalakr srbalakr commented Sep 19, 2023

Purpose

Stabilize search query generation using function calls as one approach. This example also illustrate function call to get structure response in rag sample.

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Collaborator

@pamelafox pamelafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is breaking with a ruff linter issue. Please also run the tests to see if they still pass, I believe you'll need to update some mocks. Let me know if I can help with the tests.

@srbalakr
Copy link
Collaborator Author

The CI is breaking with a ruff linter issue. Please also run the tests to see if they still pass, I believe you'll need to update some mocks. Let me know if I can help with the tests.

The CI is breaking with a ruff linter issue. Please also run the tests to see if they still pass, I believe you'll need to update some mocks. Let me know if I can help with the tests.

Addressed comments and added Ut's. Help take a look.

@srbalakr srbalakr merged commit 7b7e6ce into main Sep 21, 2023
4 checks passed
HughRunyan pushed a commit to RMI/RMI_chatbot that referenced this pull request Mar 26, 2024
* Use function call to stabilize search query

* minor changes

* sort imports

* fix ruff

* s

* Update app/backend/approaches/chatreadretrieveread.py

Co-authored-by: Pamela Fox <[email protected]>

* s

* blacj format

* add test

* save

---------

Co-authored-by: Pamela Fox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants