Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(frontend): tooltips + prettier #46

Closed
wants to merge 1 commit into from
Closed

Feature(frontend): tooltips + prettier #46

wants to merge 1 commit into from

Conversation

diberry
Copy link

@diberry diberry commented Oct 24, 2023

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@dantelmomsft
Copy link
Collaborator

dantelmomsft commented Oct 27, 2023

@johnoliver can you have a look and see if changes are required or if this is going to create UI regression in case we merge #44

@dantelmomsft dantelmomsft self-requested a review October 27, 2023 07:28
@johnoliver
Copy link
Contributor

johnoliver commented Oct 31, 2023

After the conflicts are resolved it seems to compile ok, and I am fine with the code in general, however testing I cannot see the tooltips within the UI, is this PR still functional since the recent UI updates? @diberry

@diberry
Copy link
Author

diberry commented Oct 31, 2023

@johnoliver I'm not sure what the recent UI updates are. I'll take a look and see if this is still relevant. Can you leave open for a few days?

@johnoliver
Copy link
Contributor

@johnoliver I'm not sure what the recent UI updates are. I'll take a look and see if this is still relevant. Can you leave open for a few days?

Yeah of course, no problem

@brunoborges
Copy link
Member

Hey @diberry we spoke about this today. Let us know when it is ready for review.

@brunoborges brunoborges marked this pull request as draft November 1, 2023 17:04
@diberry diberry closed this by deleting the head repository Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants