-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semantic kernel vector store approaches #106
base: main
Are you sure you want to change the base?
Conversation
String indexName; | ||
|
||
@Value("${openai.chatgpt.deployment}") | ||
private String gptChatDeploymentModelId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not required. we can delete this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still use these variables. The embedding generation service and chat completion service in SK need their models as input.
...nai/samples/rag/ask/approaches/semantickernel/JavaSemanticKernelWithVectorStoreApproach.java
Show resolved
Hide resolved
...amples/rag/chat/approaches/semantickernel/JavaSemanticKernelWithVectorStoreChatApproach.java
Show resolved
Hide resolved
...amples/rag/chat/approaches/semantickernel/JavaSemanticKernelWithVectorStoreChatApproach.java
Show resolved
Hide resolved
...amples/rag/chat/approaches/semantickernel/JavaSemanticKernelWithVectorStoreChatApproach.java
Outdated
Show resolved
Hide resolved
...nai/samples/rag/ask/approaches/semantickernel/JavaSemanticKernelWithVectorStoreApproach.java
Outdated
Show resolved
Hide resolved
); | ||
|
||
// STEP 3: Retrieve relevant documents using keywords extracted from the chat history | ||
String conversationString = ChatGPTUtils.formatAsChatML(questionOrConversation.toOpenAIChatMessages()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a duplication. let's use SK ChatHistory we have in conversation variable at line 72
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this case, ChatGPTUtils.formatAsChatML
receives a list of List<ChatRequestMessage>
which is not available from the ChatHistory. ChatHistory has List<ChatMessageTextContent>
.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information