Skip to content

Commit

Permalink
Fix a number of azd issues and docs
Browse files Browse the repository at this point in the history
  • Loading branch information
johnoliver committed Oct 10, 2023
1 parent 8a615d4 commit 3298753
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 1 deletion.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,13 @@ If you already have existing Azure resources, you can re-use those by setting `a
#### Existing resource group

1. Run `azd env set AZURE_RESOURCE_GROUP {Name of existing resource group}`
1. Run `azd env set AZURE_LOCATION {Location of existing resource group}`
1. Run `azd env set AZURE_LOCATION {Location of existing resource group (i.e eastus2)}`

This comment has been minimized.

Copy link
@dsgrieve

dsgrieve Oct 18, 2023

should be (e.g., eastus2) here and elsewhere where you are giving an example.


#### Existing OpenAI resource

1. Run `azd env set AZURE_OPENAI_SERVICE {Name of existing OpenAI service}`
1. Run `azd env set AZURE_OPENAI_RESOURCE_GROUP {Name of existing resource group that OpenAI service is provisioned to}`
1. Run `azd env set AZURE_OPENAI_SERVICE_LOCATION {Location of existing resource (i.e eastus2)}`. Only needed if your OpenAI resource is in a different location than the one you'll pick for the `azd up` step.
1. Run `azd env set AZURE_OPENAI_CHATGPT_DEPLOYMENT {Name of existing ChatGPT deployment}`. Only needed if your ChatGPT deployment is not the default 'chat'.
1. Run `azd env set AZURE_OPENAI_EMB_DEPLOYMENT {Name of existing GPT embedding deployment}`. Only needed if your embeddings deployment is not the default 'embedding'.

Expand Down
Empty file modified app/backend/mvnw
100644 → 100755
Empty file.
4 changes: 4 additions & 0 deletions infra/core/ai/cognitiveservices.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ resource account 'Microsoft.CognitiveServices/accounts@2023-05-01' = {
properties: {
customSubDomainName: customSubDomainName
publicNetworkAccess: publicNetworkAccess
networkAcls: {
bypass: 'AzureServices'
defaultAction: 'Allow'
}
}
sku: sku
}
Expand Down
3 changes: 3 additions & 0 deletions infra/main.parameters.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
"openAiResourceGroupName": {
"value": "${AZURE_OPENAI_RESOURCE_GROUP}"
},
"openAiResourceGroupLocation": {
"value": "${AZURE_OPENAI_SERVICE_LOCATION}"
},
"openAiSkuName": {
"value": "S0"
},
Expand Down

0 comments on commit 3298753

Please sign in to comment.