Bugfix/fix null reference exceptions #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If $kerberosTicketEncryptionClient is an array with one element or more, it then tries to read null. The down-level check for "Your operating system does not support the property 'EncryptionCiphers'" was not working correctly The $azureStorageIdentity.SID / DomainSID properties should be used directly, rather than using the .Value The Set-ADAccountPassword cmdlet should be called with a DistinguishedName string not the raw result of Get-AzStorageAccountADObject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I needed to do to get the script to run reliably on Server 2019, Powershell 7.3.1
In Debug-KerberosTicketEncryption - if $kerberosTicketEncryptionClient is an array with 1 element, the condition then goes on to try to read the .Value property, which is $null. Then .ToString() on this gives a null reference. I added a check to cope with this.
The check for EncryptionCiphers
(Get-SmbServerConfiguration).PSobject.Properties.Name -contains "EncryptionCiphers"was missing an outer set of brackets which stopped it from detecting that this property was missing on down-level servers.
There were a number of calls to the .Value property of the SID - this is a string already so we get $null rather than the desired value - causing null reference exceptions.
The Set-ADAccountPassword cmdlet takes a string DN in the -Identity property, not an object.