-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add video dubbing client tool and API client sample code. #325
base: master
Are you sure you want to change the base?
Add video dubbing client tool and API client sample code. #325
Conversation
See https://www.1eswiki.com/wiki/How_to_Securely_Configure_Package_Source_Files for details. | ||
--> | ||
<clear /> | ||
<add key="CustomVoiceTools-TTSDeploymentAgent" value="https://speechoutput.pkgs.visualstudio.com/VideoTranslationSamples/_packaging/VideoTranslationSamples-ApiSampleCode/nuget/v3/index.json" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
@@ -0,0 +1,174 @@ | |||
namespace Microsoft.SpeechServices.CommonLib.CommandParser; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Azure-Samples/Cognitive-Speech-TTS is retiring. Please put sample code here https://github.com/Azure-Samples/cognitive-services-speech-sdk/tree/master/samples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved.
@@ -0,0 +1,46 @@ | |||
namespace Microsoft.SpeechServices.CommonLib.CommandParser; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add copy right information on each code file like this.
https://github.com/Azure-Samples/cognitive-services-speech-sdk/blob/master/samples/custom-voice/csharp/CustomVoiceSample/Program.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
using System.Runtime.Serialization; | ||
|
||
[DataContract] | ||
public enum DeploymentEnvironment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only keep enum that works for Video Translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed unused.
@@ -0,0 +1,2 @@ | |||
Nuget: | |||
1. Not upgrade Flurl to 4.0 due to 4.0 doesn't support NewtonJson for ReceiveJson. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have readme.md. Why not merge this information into readme.md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to both places.
|
||
public readonly static IEnumerable<DeploymentEnvironment> SupportedEnvironments = new[] | ||
{ | ||
DeploymentEnvironment.Local, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't expose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
@@ -0,0 +1,19 @@ | |||
# Video Dubbing | |||
|
|||
Video dubbing client tool and API sample code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide details about how to run the command line tool. Don't expect user real the code before run.
No description provided.