Removed priority queue in favor of simple array extension #1157
+38
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I began taking appart the app and trying to get a
jsconfig.json
that would allow me to jump to source going. While working on trying to setup a path to partial esm adoption I was able to process most dependencies by mounting them to the window global but this lib is written incommonjs
. I decided to replace it with this couple of lines ofES6
.Motivation
Note there is a
<script type="module">
added and the non module scripts reference the module through the globalThis object. I have used this pattern when modernizing large projects to allow for gradual adoption of ESM. ESM leads to clearer module boundaries -> clear module boundaries lead to typedefs -> typedefs lead to typescript. My hope is that I can remove most of these /libs through newer ES features. By my calculations this repo is already using ES2021 features in master so I don't think this is too big a stretch.Type of change
Versioning
I am not sure how to do the file hash