📈 Fix #29 Added test coverage on everything, codecov at 100%

conftest.py

@@ -60,9 +60,11 @@ def create_test_user():
         add_person(session, models.Person(**USER_TEST))
         session.commit()
         filtro = session.exec(
-            select(models.User).where(models.Person.email == user)
+            select(models.Person, models.User)
+            .join(models.User)
+            .where(models.Person.email == user)
         ).first()
-    return user, filtro.password
+    return user, filtro[1].password
 
 
 def create_test_database(func):

dundie/VERSION.txt

@@ -1 +1 @@
-1.0.2.dev1+g136dc97.d20240420
+1.1.1.dev1+g136dc97.d20240420

dundie/__main__.py

@@ -1,4 +1,4 @@
-from dundie.cli import main
+from dundie.cli import main  # pragma: no cover
 
-if __name__ == "__main__":
+if __name__ == "__main__":  # pragma: no cover
     main()

dundie/core.py

@@ -10,7 +10,7 @@
 
 from dundie.database import get_session
 from dundie.models import Movement, Person
-from dundie.settings import DATEFMT
+from dundie.settings import API_BASE_URL, DATEFMT
 from dundie.utils.db import add_movement, add_person
 from dundie.utils.exchange import get_rates
 from dundie.utils.json_serealizer import DecimalEncoder
@@ -27,15 +27,11 @@
 
 
 class InvalidBeneficiaryError(Exception):
-    """
-    Exceção personalizada para erros de autenticação.
-    """
+    pass
 
 
 class InsufficientBalanceError(Exception):
-    """
-    Exceção personalizada para erros de autenticação.
-    """
+    pass
 
 
 @check_login
@@ -94,7 +90,7 @@ def read(show=False, **query: Query) -> ResultDict:
             select(Person.currency).distinct(Person.currency)
         )
 
-        rates = get_rates(currencies)
+        rates = get_rates(currencies=currencies, url=API_BASE_URL)
 
         results = session.exec(sql)
         for person in results:
@@ -163,11 +159,16 @@ def transfer(value: int, **to: Query) -> tuple[int, list]:
                 "\n❌ [ERROR] Insufficient balance to complete the transfer.\n"
             )
 
-    except (InsufficientBalanceError, InvalidBeneficiaryError) as e:
+    except InsufficientBalanceError as e:
         log.error(str(e).strip())
         console.print(e, style="danger")
         sys.exit(3)
 
+    except InvalidBeneficiaryError as e:
+        log.error(str(e).strip())
+        console.print(e, style="danger")
+        sys.exit(7)
+
     with get_session() as session:
         email = os.getenv("DUNDIE_EMAIL")
         instance_user = session.exec(

dundie/models.py

@@ -9,10 +9,6 @@
 
 
 class InvalidEmailError(Exception):
-    """
-    Exceção personalizada para erros de autenticação.
-    """
-
     pass
 
 
@@ -34,8 +30,8 @@ def validate_email(cls, v: str) -> str:
             raise InvalidEmailError(f"Invalid email for {v!r}")
         return v
 
-    def __str__(self) -> str:
-        return f"{self.name} - {self.role}"
+    # def __str__(self) -> str:
+    #     return f"{self.name} - {self.role}"
 
 
 class Balance(SQLModel, table=True):

dundie/utils/exchange.py

@@ -4,7 +4,6 @@
 import httpx
 from pydantic import BaseModel, Field
 
-from dundie.settings import API_BASE_URL
 from dundie.utils.log import log
 
 
@@ -15,14 +14,14 @@ class USDRate(BaseModel):
     value: Decimal = Field(alias="high")
 
 
-def get_rates(currencies: List[str]) -> Dict[str, USDRate]:
+def get_rates(currencies: List[str], url: str) -> Dict[str, USDRate]:
     """get current rate for USD vs Currency"""
     return_data = {}
     for currency in currencies:
         if currency == "USD":
             return_data[currency] = USDRate(high=1)
         else:
-            response = httpx.get(API_BASE_URL.format(currency=currency))
+            response = httpx.get(url.format(currency=currency))
             if response.status_code == 200:
                 data = response.json()[f"USD{currency}"]
                 return_data[currency] = USDRate(**data)

dundie/utils/json_serealizer.py

@@ -6,4 +6,4 @@ class DecimalEncoder(json.JSONEncoder):
     def default(self, obj):
         if isinstance(obj, Decimal):
             return str(obj)
-        return super().default(obj)
+        # return super().default(obj)

dundie/utils/login.py

@@ -15,9 +15,7 @@
 
 
 class AuthenticationLimitError(Exception):
-    """
-    Exceção personalizada para erros de autenticação.
-    """
+    pass
 
 
 def access_allowed() -> bool:
@@ -26,6 +24,10 @@ def access_allowed() -> bool:
     """
     email = os.getenv("DUNDIE_EMAIL")
     senha = os.getenv("DUNDIE_PASSWORD")
+
+    if (email and senha) is None:
+        return None
+
     with get_session() as session:
         filter_user = session.exec(
             select(Person)
@@ -105,9 +107,20 @@ def wrapper(*args, **kwargs):
                     # Se o usuário estiver logado a função original é executada
                     return func(*args, **kwargs)
 
-                else:
+                if access_allowed() is None:
                     attempts += login_attempts(attempts)
                     continue
+
+                if not access_allowed():
+                    message_attempt_error = (
+                        "\n❌ [ERROR] email or password exported in"
+                        "environment variables are incorrect\n"
+                    )
+                    console.print(message_attempt_error, style="danger")
+                    log.error(message_attempt_error.strip())
+                    attempts += login_attempts(attempts)
+                    continue
+
             raise AuthenticationLimitError(
                 "\n❌ [ERROR] You have reached the authentication limit,"
                 " please try again later..."

dundie/utils/permission.py

@@ -14,9 +14,7 @@
 
 
 class PermissionDenied(Exception):
-    """
-    Exceção personalizada para erros de autenticação.
-    """
+    pass
 
 
 def get_user_role_dept():

integration/test_add.py

@@ -0,0 +1,56 @@
+import pytest
+from click.testing import CliRunner
+from conftest import create_test_database
+
+from dundie.cli import load, main
+
+from .constants import PEOPLE_FILE
+
+cmd = CliRunner()
+
+
+@pytest.mark.integration
+@pytest.mark.medium
+@create_test_database
+def test_add_positive_call_add_command_filter_dept():
+    """test command load"""
+    cmd.invoke(load, PEOPLE_FILE)
+    out = cmd.invoke(main, ["add", "200", "--dept=Sales"])
+    assert "Dunder Mifflin Report" in out.output
+    assert "Sales" in out.output
+    assert "Direct" not in out.output
+
+
+@pytest.mark.integration
+@pytest.mark.medium
+@create_test_database
+def test_add_negative_call_add_command_filter_dept():
+    """test command load"""
+    cmd.invoke(load, PEOPLE_FILE)
+    out = cmd.invoke(main, ["add", "sdasd", "--dept=Sales"])
+    assert "'sdasd' is not a valid integer" in out.output
+    assert 2 == out.exit_code
+
+
+@pytest.mark.integration
+@pytest.mark.medium
+@create_test_database
+def test_add_positive_call_add_command_filter_email():
+    """test command load"""
+    cmd.invoke(load, PEOPLE_FILE)
+    out = cmd.invoke(main, ["add", "200", "[email protected]"])
+    assert "Dunder Mifflin Report" in out.output
+    assert "jim@du" in out.output
+    assert "Dwight" not in out.output
+
+
+@pytest.mark.integration
+@pytest.mark.medium
+@create_test_database
+def test_add_negative_call_add_command_filter_email():
+    """test command load"""
+    cmd.invoke(load, PEOPLE_FILE)
+    out = cmd.invoke(main, ["add", "-200", "[email protected]"])
+    assert "No such option:" in out.output
+    assert "-2" in out.output
+    assert 2 == out.exit_code

integration/test_movements.py

@@ -0,0 +1,18 @@
+import pytest
+from click.testing import CliRunner
+from conftest import create_test_database
+
+from dundie.cli import movements
+
+cmd = CliRunner()
+
+
+@pytest.mark.integration
+@pytest.mark.medium
+@create_test_database
+def test_movements_positive_call():
+    out = cmd.invoke(movements)
+    assert "Dunder Mifflin Movements" in out.output
+    assert "500" in out.output
+    assert "Date" in out.output
+    assert "system" in out.output

integration/test_remove.py

@@ -0,0 +1,58 @@
+import pytest
+from click.testing import CliRunner
+from conftest import create_test_database
+
+from dundie.cli import load, main
+
+from .constants import PEOPLE_FILE
+
+cmd = CliRunner()
+
+
+@pytest.mark.integration
+@pytest.mark.medium
+@create_test_database
+def test_remove_positive_call_add_command_filter_dept():
+    """test command load"""
+    cmd.invoke(load, PEOPLE_FILE)
+    out = cmd.invoke(main, ["remove", "200", "--dept=Sales"])
+    assert "Dunder Mifflin Report" in out.output
+    assert "Sales" in out.output
+    assert "Direct" not in out.output
+
+
+@pytest.mark.integration
+@pytest.mark.medium
+@create_test_database
+def test_remove_negative_call_add_command_filter_dept():
+    """test command load"""
+    cmd.invoke(load, PEOPLE_FILE)
+    out = cmd.invoke(main, ["remove", "sdasd", "--dept=Sales"])
+    assert "'sdasd' is not a valid integer" in out.output
+    assert 2 == out.exit_code
+
+
+@pytest.mark.integration
+@pytest.mark.medium
+@create_test_database
+def test_remove_positive_call_add_command_filter_email():
+    """test command load"""
+    cmd.invoke(load, PEOPLE_FILE)
+    out = cmd.invoke(main, ["remove", "200", "[email protected]"])
+    assert "Dunder Mifflin Report" in out.output
+    assert "jim@du" in out.output
+    assert "Dwight" not in out.output
+
+
+@pytest.mark.integration
+@pytest.mark.medium
+@create_test_database
+def test_remove_negative_call_add_command_filter_email():
+    """test command load"""
+    cmd.invoke(load, PEOPLE_FILE)
+    out = cmd.invoke(
+        main, ["remove", "-200", "[email protected]"]
+    )
+    assert "No such option:" in out.output
+    assert "-2" in out.output
+    assert 2 == out.exit_code