Multi-tenancy extension documentation #290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added description of command line arguments valid for all commands
Co-authored-by: Steven van Beelen <[email protected]>
Co-authored-by: Steven van Beelen <[email protected]>
Co-authored-by: Steven van Beelen <[email protected]>
Co-authored-by: Steven van Beelen <[email protected]>
Co-authored-by: Steven van Beelen <[email protected]>
Co-authored-by: Steven van Beelen <[email protected]>
Co-authored-by: Steven van Beelen <[email protected]>
Co-authored-by: Steven van Beelen <[email protected]>
This reverts commit 4fe8f42
Adjust DLQ intro section by: * adding a small introduction, * replacing event processor mentions for processing group, * add details on maintaining a dead letter sequence #281
Adjust DLQ configuration section by: * adjusting the indentation, * slightly adjusting the samples, * replacing mentions of event processor with processing group #281
Adjust DLQ processing section by: * expanding the intro section by explaining the SequencedDeadLetterProcessor and its methods, * adjust the sample titles * adjusting the indentation, * replacing repair for retry in the samples as there is no guarantee the letter is not enqueued again, * replacing mentions of event processor with processing group #281
Adjust DLQ attributes section by: * fix the section title, * use code sections, * remove markTouched, withCause and withDiagnostics, * change message type to EventMessage * change cause type to Optional<Cause>, * explain why the cause may be empty, * explain that diagnostics are filled through an EnqueuePolicy #281
Adjust DLQ policy section by: * introduce desire to not enqueue at all times, * introduce EnqueuePolicy and EnqueueDecision, * explain when the policy kicks in, * explain scenario when to configure a custom policy, * separate the policy creation and configuration into two sample sections * use several Decisions operations to showcase it. #281
Co-authored-by: Mitchell Herrijgers <[email protected]>
Co-authored-by: Mitchell Herrijgers <[email protected]>
Co-authored-by: Mitchell Herrijgers <[email protected]>
Co-authored-by: Mitchell Herrijgers <[email protected]>
Co-authored-by: Mitchell Herrijgers <[email protected]>
Co-authored-by: Mitchell Herrijgers <[email protected]>
Co-authored-by: Mitchell Herrijgers <[email protected]>
Co-authored-by: Mitchell Herrijgers <[email protected]>
Co-authored-by: Mitchell Herrijgers <[email protected]>
Process review comments by adjusting and further fine-tuning description of: - the importance of sequencing dead letter, - where to find the SequencedDeadLetterProcessor, - the description of the message attribute, - the enqueue decision intro description, - a better example on diagnostics usage. #281
Co-authored-by: Steven van Beelen <[email protected]>
smcvb
requested changes
Nov 4, 2022
| @@ -254,6 +254,43 @@ axonserver-cli.jar <Command> <command options> -S <server-to-send-command-to> - | |||
|
|
|||
| The option -S with the url to the Axon Server is optional, if it is omitted it defaults to [http://localhost:8024](http://localhost:8024/). While for Axon Server SE, the URL for the Axon Server SE will be the single running node, for Axon Server EE, the URL should be pointing to any node serving the _\_admin_ context within an Axon Server EE cluster. | |||
|
|
|||
| The `<command options>` valid for all commands, are: `-S`, `-s`, `-i`, `-o`. | |||
There was a problem hiding this comment.
I wouldn't expect this change in your pull request to be honest 🤔
There was a problem hiding this comment.
Granted, the commit log as shown by GitHub strikes me as odd too.
| @@ -60,7 +60,7 @@ public class KafkaEventPublicationConfiguration { | |||
| } | |||
| ``` | |||
|
|
|||
| The second infrastructure component to introduce is the `KafkaPublisher`, which has a hard requirement on the `ProducerFactory`. Additionally, this would be the place to define the Kafka topic upon which Axon event messages will be published. Note that the `KafkaPublisher` needs to be `shutDown` properly, to ensure all `Producer` instances are properly closed. | |||
| The second infrastructure component to introduce is the `KafkaPublisher`, which has a hard requirement on the `ProducerFactory`. Additionally, this would be the place to define the Kafka topics upon which Axon event messages will be published. You can set a function from event to `Optional<String>`. You can use this to only publish certain events, or put different events to different topics. Its not uncommon for Kafka topics to only contain one type of message. Note that the `KafkaPublisher` needs to be `shutDown` properly, to ensure all `Producer` instances are properly closed. | |||
There was a problem hiding this comment.
I wouldn't expect these changes in your pull request either 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With adjusted PR comments from previous PR