Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

docs: improve react documentation #209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lekoaf
Copy link
Member

@lekoaf lekoaf commented Jun 2, 2022

Describe your changes

Adds a basic react example to the readme and shows the interface for the Player component.

Issue ticket number and link

  • Fixes #(issue)

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@lekoaf lekoaf requested a review from Tigge as a code owner June 2, 2022 08:20
@lekoaf lekoaf requested review from steabert and barnomasoz June 2, 2022 08:20
@lekoaf
Copy link
Member Author

lekoaf commented Jun 2, 2022

This PR also removes the unused aspectRatio property from the interface.

Adds a basic react example to the readme
and shows the interface for the Player component.
Copy link
Collaborator

@barnomasoz barnomasoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants