Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade @fluentui deps and use react v17 #21

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

steabert
Copy link
Member

@steabert steabert commented Oct 4, 2023

Updates all @FluentUI dependencies to latest version.

Since there is a problem with @types/react v18 causing type errors in slot properties, all react dependencies used in the repo are set to v17, which is the same version @FluentUI uses. Peer dependencies for react still allow v18.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@steabert steabert requested a review from a team as a code owner October 4, 2023 05:47
@steabert steabert force-pushed the fluent-update branch 2 times, most recently from 0d5e539 to 380fa85 Compare October 4, 2023 07:58
Updates all @FluentUI dependencies to latest version.

Since there is a problem with @types/react v18 causing type errors in
slot properties, all react dependencies used in the repo are set to v17,
which is the same version @FluentUI uses. Peer dependencies for react
still allow v18.
@steabert steabert merged commit f829d89 into main Oct 4, 2023
3 checks passed
@steabert steabert deleted the fluent-update branch October 4, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants