Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(topbar): add beta label to selected app #14

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix(topbar): add beta label to selected app #14

merged 1 commit into from
Sep 27, 2023

Conversation

steabert
Copy link
Member

@steabert steabert commented Sep 27, 2023 •
edited
Loading

The selected application in the app menu should still have the beta label.

image

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@steabert steabert requested a review from a team as a code owner September 27, 2023 09:11
@steabert steabert changed the title fix: add beta label to selected app fix(topbar): add beta label to selected app Sep 27, 2023
@steabert
fix(topbar): add beta label to selected app
f687a82 
The selected application in the app menu should still
have the beta label.
axis-d0op
axis-d0op approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@axis-d0op axis-d0op left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steabert steabert self-assigned this Sep 27, 2023
markuslindmark
markuslindmark approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@markuslindmark markuslindmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steabert steabert merged commit 27f2067 into main Sep 27, 2023
@steabert steabert deleted the topbar-beta branch September 27, 2023 12:05
@steabert steabert mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axis-d0op axis-d0op axis-d0op approved these changes

@markuslindmark markuslindmark markuslindmark approved these changes

Assignees

@steabert steabert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steabert @markuslindmark @axis-d0op