fix(oidc): force sw update when new registration appears (release) #1449
Conversation
wermanoid
force-pushed
the
fix/update-sw-registration
branch
from
5bcf899 to
4c83439
Compare
|
|
||
| if (registration.active && registration.waiting) { | ||
| console.log('Detected new service worker waiting, unregistering and reloading'); | ||
| await configuration.service_worker_update_require_callback?.(registration, stopKeepAlive); |
There was a problem hiding this comment.
hi @wermanoid thank you for your PullRequest !
I'am not sure to understand why we nee 2 time await configuration.service_worker_update_require_callback?.(registration, stopKeepAlive); ? may you help me to understand?
There was a problem hiding this comment.
there are cases when new service worker is added, when old one is still running. This leads to case when SW is just hanging in waitting state and never starts, as original SW is still running as usual.
As far as I understand now, oidc is able to update SW only when running SW version and oidc version mismatch.
But we had cases when ui was redeployed and that leads to case, when 2 SW of same internal oidc version appeared in browser.
There was a problem hiding this comment.
Thanh you @wermanoid I will test your version tomorrow! sorry for the delay.
There was a problem hiding this comment.
Hi @guillaume-chervet , any chance to verify? Or can I help somehow to move forward?
There was a problem hiding this comment.
I checked it referring to my Issue #1400
I can't reproduce the sw mismatched versions issue anymore in demo app running from wermanoid:fix/update-sw-registration
guillaume-chervet
force-pushed
the
main
branch
from
4f9ca8e to
ad18d60
Compare
|
very very sorry for the delay @wermanoid |
Should help with #1400
Also allow to update SW when some code changes happens within same version. At lest existing
service_worker_update_require_callbackwas effective enough for me in private app tests and with react-oidc-demo app too. I didn't fail in any reload loop, since SW copy function was added to app prestart.@piotrbartnik @guillaume-chervet would be great if you could prove that it works or not at yours environment