fix(oidc): record tabIds when service worker receives init event (release) #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guillaume-chervet could you take a look? This is follow-up for #1402 |
guillaume-chervet
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix from #1402 has one issue - if
allowMultiTabLoginflag is true and second tab is opened (when first tab is already authenticated), trying to initiate token renewal (using refresh token) from second tab fails. This is because previously tabId was saved to database only when login flow was initiated from given tab. This fix adds registering of tab id each time service worker receivesinitevent.A picture tells a thousand words
Before this PR
After this PR