Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add URL normalization for getCurrentDatabaseDomain endpoints comparison #1196

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix: add URL normalization for getCurrentDatabaseDomain endpoints comparison #1196

merged 1 commit into from
Nov 17, 2023

Conversation

meesvandongen
Copy link
Contributor

@meesvandongen meesvandongen commented Nov 16, 2023 •
edited
Loading

fixes #1189

@meesvandongen
Copy link
Contributor Author

I took normalize-url and removed some unneeded rules, I can probably bring it down even further by ignoring things that don't make sense for a user to input; for example the trim

@guillaume-chervet
Copy link
Contributor

Thank you @meesvandongen , i test it right now.

@guillaume-chervet guillaume-chervet self-requested a review November 17, 2023 11:18
@guillaume-chervet
Copy link
Contributor

Thank you very much @meesvandongen

@guillaume-chervet guillaume-chervet merged commit 8d7a06a into AxaFrance:main Nov 17, 2023
13 checks passed
guillaume-chervet pushed a commit that referenced this pull request Nov 17, 2023
@meesvandongen @guillaume-chervet
fix(sevice-worker): add URL normalization for getCurrentDatabaseDomai…
5085e05 
…n endpoints comparison (release) (#1196)

Co-authored-by: Mees van Dongen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaume-chervet guillaume-chervet guillaume-chervet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalize URLs in OidcServiceWorker.js
2 participants
@meesvandongen @guillaume-chervet