fix(look&feel): select id and label optional (#773)

Co-authored-by: Jonathan VACHERAT <[email protected]>
AxaFrance · Jan 20, 2025 · 3522526 · 3522526
1 parent c950411
commit 3522526
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/client/look-and-feel/react/src/Form/Select/Select.stories.tsx b/client/look-and-feel/react/src/Form/Select/Select.stories.tsx
@@ -30,7 +30,6 @@ export const SelectStory: Story = {
     className: "",
     options,
     label: "Label",
-    id: "nameid",
     disabled: false,
     required: false,
     placeholder: "Placeholder",

diff --git a/client/look-and-feel/react/src/Form/Select/Select.tsx b/client/look-and-feel/react/src/Form/Select/Select.tsx
@@ -21,8 +21,8 @@ type Props = Omit<
   ComponentPropsWithRef<ReactSelect>,
   "placeholder" | "noOptionsMessage"
 > & {
-  id: string;
-  label: string;
+  id?: string;
+  label?: string;
   options: { label: string; value?: string | number | readonly string[] }[];
   value: Option | null;
   errorLabel?: string;
@@ -57,7 +57,7 @@ const Select = forwardRef<
     inputId = id || inputId;
 
     return (
-      <>
+      <div>
         {label && (
           <label htmlFor={inputId} className="af-form__select-label">
             {label}
@@ -120,7 +120,7 @@ const Select = forwardRef<
           ref={inputRef}
         />
         {errorLabel && <InputError id={idError} message={errorLabel} />}
-      </>
+      </div>
     );
   },
 );