Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to Windows Package Managar (WinGet) #291

Closed
wants to merge 5 commits into from

Conversation

vedantmgoyal9
Copy link

This action automatically generates manifests for WinGet Community Repository (microsoft/winget-pkgs) and submits them.

Before merging this:

  1. Please add a GitHub token with public_repo scope as a repository secret and rename the secret name in the workflow.
  2. Fork microsoft/winget-pkgs under @AviSynth.

@vedantmgoyal9
Copy link
Author

vedantmgoyal9 commented Jun 27, 2022

@qyot27 the PR updates the installer to remove the revision number from the installer so that it matches the version from GitHub release tag (without v).

@qyot27
Copy link
Member

qyot27 commented Jun 27, 2022

Does winget even allow itself to be used on XP? Because you could just have it use the regular vcredist.

I wonder if the AppVersion change shouldn't actually be ifdeffed in the section just below it, since - IIRC - the RevisionNumber is largely there for the in-between dev test builds that occasionally get their own installers (not that we'd recommend pushing those out through any package management system, just that they do exist).

Apart from that, I don't actually interact with the Github automation, so I can't really give any feedback on that side.

@vedantmgoyal9
Copy link
Author

@qyot27 I can revert the changes in the ISS file, by the way, if we can include the revision version in the GitHub release tag, it would serve the purpose.

Apart from that, I don't actually interact with the Github automation, so I can't really give any feedback on that side.

I can help in the process of creating the token and adding it to the repository secret :)

@vedantmgoyal9
Copy link
Author

vedantmgoyal9 commented Sep 25, 2022

@qyot27 Hello 👋🏻 again! I have updated the workflow and now only 3 things are needed from your side.

  1. Please add a GitHub token with public_repo and workflow scope as a repository secret and rename the secret name in the workflow.
  2. Fork microsoft/winget-pkgs under @AviSynth.
  3. Merge the PR, and on next release, AviSynth will be automatically published to WinGet.

@vedantmgoyal9
Copy link
Author

cc @qyot27

@qyot27
Copy link
Member

qyot27 commented Oct 22, 2022

I won't block it if @pinterf wants to go ahead with it, but adding multiple things to the project backend for one package manager (when we currently don't do any in-project handling for any other package management system) is ultimately not something I'm particularly inclined to do myself.

@qyot27 qyot27 closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants