-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish to Windows Package Managar (WinGet) #291
Conversation
@qyot27 the PR updates the installer to remove the revision number from the installer so that it matches the version from GitHub release tag (without v). |
Does winget even allow itself to be used on XP? Because you could just have it use the regular vcredist. I wonder if the AppVersion change shouldn't actually be ifdeffed in the section just below it, since - IIRC - the RevisionNumber is largely there for the in-between dev test builds that occasionally get their own installers (not that we'd recommend pushing those out through any package management system, just that they do exist). Apart from that, I don't actually interact with the Github automation, so I can't really give any feedback on that side. |
@qyot27 I can revert the changes in the ISS file, by the way, if we can include the revision version in the GitHub release tag, it would serve the purpose.
I can help in the process of creating the token and adding it to the repository secret :) |
@qyot27 Hello 👋🏻 again! I have updated the workflow and now only 3 things are needed from your side.
|
cc @qyot27 |
I won't block it if @pinterf wants to go ahead with it, but adding multiple things to the project backend for one package manager (when we currently don't do any in-project handling for any other package management system) is ultimately not something I'm particularly inclined to do myself. |
This action automatically generates manifests for WinGet Community Repository (microsoft/winget-pkgs) and submits them.
Before merging this:
public_repo
scope as a repository secret and rename the secret name in the workflow.