Removes .orig file, add yml file to Package source exclusions
#289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpassis
changed the title
.orig file, add openapi.yml to Package source exclusions.orig file, add create-api.yml to Package source exclusions
rpassis
changed the title
.orig file, add create-api.yml to Package source exclusions.orig file, add yml file to Package source exclusions
Code Coverage Report
Generated by 🚫 Danger Swift against 18469ae |
AvdLee
requested changes
Nov 26, 2024
Package.swift
Outdated
Comment on lines
38
to
56
| .binaryTarget( | ||
| name: "create-api", // Find the URL and checksum at https://github.com/createapi/createapi/releases/latest | ||
| url: "https://github.com/CreateAPI/CreateAPI/releases/download/0.2.0/create-api.artifactbundle.zip", | ||
| checksum: "6f8a3ce099f07eb2655ccaf6f66d8c9a09b74bb2307781c4adec36609ddac009" | ||
| ), | ||
| .plugin( | ||
| name: "CreateAPI", | ||
| capability: .command( | ||
| intent: .custom( | ||
| verb: "generate-open-api", | ||
| description: "Generates the OpenAPI entities and paths using CreateAPI" | ||
| ), | ||
| permissions: [ | ||
| .writeToPackageDirectory(reason: "To output the generated source code") | ||
| ] | ||
| ), | ||
| dependencies: [ | ||
| .target(name: "create-api") | ||
| ] |
There was a problem hiding this comment.
I don't think we need to delete these, do we?
There was a problem hiding this comment.
Sorry that was a local change I make to test a few things, reverted now 👍
|
This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days. |
This reverts commit 18469ae.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago this
.origfile was committed and merged, possibly after resolving a merge conflict. It is redundant and generates build warnings.The same goes for
create-api.yml, which is currently part of the Sources folder but is not a swift file, so the compiler complains that it doesn't know how to handle the yml extension.