GestureRecognizerCollection remove method

[edgarfgp]

What does the pull request do?

• Updates GestureRecognizerCollection exposing a Remove method

What is the current behavior?

GestureRecognizerCollection does not expose Remove option

What is the updated/expected behavior with this PR?

Being able to remove a gesture recognizer.

How was the solution implemented (if it's not obvious)?

Checklist

• Added unit tests (if possible)?
• Added XML documentation to any related classes?
• Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #12558

[avaloniaui-team]

You can test this PR using the following package version. 11.0.999-cibuild0039129-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[avaloniaui-team]

You can test this PR using the following package version. 11.0.999-cibuild0039135-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[kekekeks]

What happens to pointers that are currently captured by removed gesture recognizer?

[edgarfgp]

What happens to pointers that are currently captured by removed gesture recognizer?

I am still going through the codebase to understand the implementation, which is why It is still a DRAFT.

I think this is taken care of by a previously merged PR #12666 ?

[timunie]

@edgarfgp no this PR will make sure a gesture is freed once focus was lost. If you want to remove a gesture, one must check if it is in use currently before removing it. So I think the API should be TryRemove(). Inside

1. check if gesture is in use
2. if 1 is true -> return false and exit method
3. if 2 passed, continue to remove and return true

Similar for TryRemoveAll, if we want to provide this.

[kekekeks]

We could release capture for removed recognizers too.

[timunie]

@kekekeks in that case I would prefer to have TryRemove and ForceRemove where force remove will release the capture where TryRemove gives the user the chance to finish the action. What do you think?

Talking to Nikita seems like removing the capture during remove should be the way to go. So ignore my comments.