Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#2322 - Log error when sequence or scenario is not consistent #2423

Merged

Conversation

trgiangdo
Copy link
Member

@trgiangdo trgiangdo commented Jan 23, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature

Description

In this PR, when a Sequence or Scenario is not consistent (the DAG is not valid), an error message is now log to better explain the error to the user.

Related Tickets & Documents

Checklist

We encourage you to keep the code coverage percentage at 80% and above.

  • This solution meets the acceptance criteria of the related issue.
  • The related issue checklist is completed.
  • This PR adds unit tests for the developed code. If not, why?
  • End-to-End tests have been added or updated. If not, why?
  • The documentation has been updated, or a dedicated issue created. (If applicable)
  • The release notes have been updated? (If applicable)

Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19644 17097 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/core/scenario/scenario.py 97% 🟢
taipy/core/sequence/sequence.py 99% 🟢
TOTAL 98% 🟢

updated for commit: 82aab35 by action🐍

@trgiangdo trgiangdo merged commit 23fc0fb into develop Jan 23, 2025
126 checks passed
@trgiangdo trgiangdo deleted the feature/#2322-log-error-when-sequence-scenario-inconsistent branch January 23, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Improvement Improvement of a feature. ✨New feature 🧪Testing Related to tests and other QA activities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Informative error messages on Scenario build failure
2 participants