Fix erratic $log_file_link and $raw_log_file_link on Debug TAB on Windows

[DrLightman]

On Windows backslashes in path break the replace. For example $log_file_link may become something like this:

http://example.org/D:/my_sites/example_org/wp-content/cache/view_e1b50ae15624d52670a4a76c4ce03610.php

Because ABSPATH value on Windows is D:\my_sites\example_org/ therefore it doesn't get replaced with the empty string.

Same goes with $raw_log_file_link since they are being generated in the same manner involving a string replacement.

[stodorovic]

@DrLightman Thanks. I think that's better to we keep str_replace. Anyway, there are two variants which could work:

• Normalization of ABSPATH:
  $abspath = functions_exists( 'wp_normalize_path' ) ? wp_normalize_path( ABSPATH ) : str_replace( '\\', '/', ABSPATH );

• Get realpath for $cache_path before str_replace (it seems as more clear solution):
  $cache_rel_path = str_replace( ABSPATH, '', wpsc_get_realpath( $cache_path ) );
$log_file_link = "<a href='" . site_url( "{$cache_rel_path}view_{$wp_cache_debug_log}" ) ....

I use cygwin on Windows and I can't test it at this moment. I'd like to we avoid substr(on this way) if it's possible. Could you please check is it working on Windows and update PR?

[DrLightman]

Hi @stodorovic can you check now? I wasn't able to make it shorter, I had to start with:

ABSPATH = D:\Sites\example_org/
$cache_path = D:\Sites\example_org\wp-content/cache/

Also, I don't know if this kind of replacement might break when an user customizes the cache location in the Advanced tab... by moving it outside the document root, is it even possibile, theoretically?

[stodorovic]

I've found old laptop with Windows XP/PHP 5.2,5.3,5.4. I've tested following code:

Suggested change

	}
	// Extracts and normalizes relative path.
	$cache_rel_path = str_replace( realpath( ABSPATH ), '', realpath( $cache_path ) );
	$cache_rel_path = str_replace( '\\', '/', $cache_rel_path );

It seems OK by first tests and it's more readable. We need only to replace \ because $cache_rel_path doesn't contain drive letter.

[stodorovic]

Suggested change

	$cache_url = site_url( $cache_url );
	$cache_url = trailingslashit( site_url( $cache_rel_path ) );

It's possible to realpath strips last slash.

[stodorovic]

I've checked on older PHP versions (windows) and it seems that we could reduce complexity. Could you check my suggestions? Is it working on your installations?
Also, there are other issues related to security rules (which often prevent access to the logs) and I've an idea to remove PHP code from logs. It's possible to serve part of logs via AJAX request.