Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Use wpcom_login instead of login when linking to user profile #98911

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Jan 24, 2025

Related to #98868
Requires diff: 171081-ghe-Automattic/wpcom

Proposed Changes

  • This PR uses wpcom_login when linking to the user profile page instead of login.

Why are these changes being made?

  • login data is inconsistent between Jetpack and wpcom sites. wpcom_login is always the wordpress.com login.

Testing Instructions

Screenshot 2025-01-24 at 4 30 37 PM Screenshot 2025-01-24 at 4 29 58 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@DustyReagan DustyReagan changed the title Use wpcom_login instead of login Reader: Use wpcom_login instead of login when linking to user profile Jan 24, 2025
@DustyReagan DustyReagan self-assigned this Jan 24, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/read-use-wpcom_login on your sandbox.

@DustyReagan DustyReagan marked this pull request as ready for review January 24, 2025 22:27
@DustyReagan DustyReagan requested a review from a team as a code owner January 24, 2025 22:27
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 24, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~0 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
write-flow                             +24 B  (+0.0%)       +0 B
reader                                 +24 B  (+0.0%)       +0 B
plugins                                +24 B  (+0.0%)       +0 B
link-in-bio-tld-flow                   +24 B  (+0.0%)       +0 B
jetpack-cloud-plugin-management        +24 B  (+0.0%)       +0 B
home                                   +24 B  (+0.0%)       +0 B
build-flow                             +24 B  (+0.0%)       +0 B
a8c-for-agencies-plugins               +24 B  (+0.0%)       +0 B

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~0 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-design-blocks                                   +24 B  (+0.0%)       +0 B
async-load-calypso-components-web-preview-component        +24 B  (+0.0%)       +0 B

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@artemiomorales artemiomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests well for me 👍

@DustyReagan DustyReagan merged commit 40ccac4 into trunk Jan 28, 2025
20 checks passed
@DustyReagan DustyReagan deleted the update/read-use-wpcom_login branch January 28, 2025 18:07
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants