Improve tracking on new Multi-site 'Add new site' button.

[andregardi]

Proposed Changes

To improving tracking on our Drive migrations from multi-site dashboard project, we are adding some changes.

• When opening the Multi-site popover, triggering calypso_sites_dashboard_new_site_action_click_open.

• Do not trigger calypso_sites_dashboard_new_site_action_click_add just from opening the popover.

• triggers:

  • calypso_sites_dashboard_new_site_action_click_add
  • calypso_sites_dashboard_new_site_action_click_item with action: 'wordpress'

• triggers:

  • calypso_sites_dashboard_new_site_action_click_jetpack
  • calypso_sites_dashboard_new_site_action_click_item with action: 'jetpack'

• triggers:

  • calypso_sites_dashboard_new_site_action_click_item with action: 'migrate'

• triggers:

  • calypso_sites_dashboard_new_site_action_click_import
  • calypso_sites_dashboard_new_site_action_click_item with action: 'import'

• triggers:

  • calypso_sites_dashboard_new_site_action_click_item with action: 'offer'

Testing Instructions

Access the dashboard with the feature flag /sites?flags=-sites%2Fdrive-migrations.
Start to listen to events. Click on each options from the new Add new site button.
Check that the events work as described above.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131055

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131055&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131055&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug agardi/multi-site-tracking on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~50 bytes added 📈 [gzipped])

name                                                      parsed_size           gzip_size
async-load-calypso-components-sites-add-new-site-content       +293 B  (+6.1%)      +50 B  (+2.9%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[gabrielcaires]

Hello 👋
I have some questions about this PR.

1. Why do we need to have two events? E.g a( calypso_sites_dashboard_new_site_action_click_jetpack and calypso_sites_dashboard_new_site_action_click_item). Technically, we use the ref parameter on each link to identify the user's origin.

2. I saw all links are using "topbar" as the ref value. Should we use a more self-explanatory like ref=new-site-popover.