-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launchpad My Home: Showing snackbar when a task was completed #98865
Open
vykes-mac
wants to merge
4
commits into
trunk
Choose a base branch
from
add/task-next-step-snackbar
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
vykes-mac
changed the title
Launchpad My Home: Showing snackbar when a task was completed
WIP Launchpad My Home: Showing snackbar when a task was completed
Jan 24, 2025
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
vykes-mac
changed the title
WIP Launchpad My Home: Showing snackbar when a task was completed
Launchpad My Home: Showing snackbar when a task was completed
Jan 25, 2025
vykes-mac
added
the
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
label
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #98839
Proposed Changes
Why are these changes being made?
Testing Instructions
Apply this branch on your local Calypso
Make sure
widgets.wp.com
is sandboxed.Run
install-plugin.sh wbe add/task-next-step-snackbar
on sandboxCreate a new post using the onboarding flag: http://calypso.localhost:3000/post/{domain}?#publish-first-post
Inspect the page and open the iFrame URL in a new tab
https://{siteSlug}/wp-admin/post.php?post=44&action=edit&calypsoify=1&block-editor=1&frame-nonce=ed0785d2f4&origin=http%3A%2F%2Fcalypso.localhost%3A3000&environment-id=development&support_user=&_support_token#publish-first-post
After publishing a post, you should see a snackbar with
next steps
linkPre-merge Checklist