-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses TLD to check for subdomain status for Mapping #98864
base: trunk
Are you sure you want to change the base?
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~334 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~229 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
const isValidSubdomain = Boolean( | ||
domainName.match( | ||
/^([a-z0-9_]([a-z0-9\-_]*[a-z0-9_])?\.)+[a-z0-9]([a-z0-9-]*[a-z0-9])?\.[a-z]{2,63}$/ | ||
) | ||
); | ||
|
||
return isValidSubdomain && getRootDomain( domainName ) !== domainName; | ||
// If it doesn't even match the subdomain "shape", just return false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered passing down the tld
param to getRootDomain
and then to getTld
? It seems it would make the code significantly simpler while keeping backward compatability for those methods if they're called without the tld
param
rather than a hardcoded list of TLDs on the Front End
relies on wpcom diff: 170938-ghe-Automattic/wpcom
Related to # https://github.com/Automattic/nomado-issues/issues/947
Proposed Changes
Why are these changes being made?
Testing Instructions
mapping-setup-info
to isolate the single API callWith fix (
assnat.qc.ca
localhost):Without fix (
assnat.qc.ca
on wordpress.com):