Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context on what 'Launch site' means #98099

Closed
wants to merge 1 commit into from

Conversation

andregardi
Copy link
Contributor

Closes #76947

Proposed Changes

image

Adds Your site is private and only visible to you. When you're ready, launch your site to make it public. description on launchpad.

This copy is already used on different areas and translation is ready to use.

image

Why are these changes being made?

Launching a site can sound too big of a change for a lot of customers. By adding context on what that change represents, we can make customers more confident, which should lead to an increase in launched sites.

Testing Instructions

  • Create a free site and follow the steps until you achieve the launchpad step.
  • You should be able to see new copy under the Launch your site button.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@andregardi andregardi self-assigned this Jan 8, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~50 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
write-flow                 +173 B  (+0.0%)      +50 B  (+0.0%)
link-in-bio-tld-flow       +173 B  (+0.0%)      +50 B  (+0.0%)
build-flow                 +173 B  (+0.0%)      +50 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@andregardi andregardi requested a review from a team January 8, 2025 17:23
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 8, 2025
@sixhours
Copy link
Contributor

sixhours commented Jan 9, 2025

This is working as described! A couple things I thought about while reviewing:

  • We should probably keep an eye on site launch rates after this ships since it could deter users from launching their sites (FWIW I don't know if we still use that metric as a benchmark for user success/engagement).
  • Maybe @fditrapani or someone from design could take a look (if they haven't already). The spacing between the button and the new copy feels a bit tight to me, but that's me being nitpicky.

@fditrapani
Copy link
Contributor

Thanks for the ping @sixhours! The spacing looks fine on my end!

I'd like to cc @autumnfjeld on this one. We're getting ready to launch an onboarding experiment (if we haven't already) and wanted to give the new experiment some time without pushing any changes to make sure the data is tracking fine. Autumn, do you see any issues with merging this PR when it's ready?

Copy link
Contributor

@gabrielcaires gabrielcaires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are showing the "Launch" button based a config we are getting from the backend.

CleanShot 2025-01-13 at 11 00 53@2x

We may have cases this launchpad component doesn't have the launch tasks.

So, before show the new text, we need to check if the current task list contains the flag "isLaunchTask" set as true.

gabrielcaires

This comment was marked as duplicate.

@autumnfjeld
Copy link
Contributor

Here is helpful discussion on the onboarding experiment
p1736803549963059/1736797618.525879-slack-C085HCWCEDN. Going forward changes are shipped to the treatment group (the goals-first flow).

This discussion p1736797862169599/1736797618.525879-slack-C085HCWCEDN shares which metrics the data team is watching, for example signup completions and cash sales. @isatuncman-auto

Please wait a couple days to merge this. p1736803549963059/1736797618.525879-slack-C085HCWCEDN
Middle of this week (Jan 15) would be fine.

@richtabor
Copy link

I suggest we close this, as this view is being phased out for an in-WordPress launchpad.

However, I do think it's important to make launching more meaningful, so I've started #98860 to formulate a plan on how we can do this considering the revised path forward.

@richtabor richtabor closed this Jan 24, 2025
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: [Launchpad] Add context on what "Launch site" means
7 participants