-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context on what 'Launch site' means #98099
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~50 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This is working as described! A couple things I thought about while reviewing:
|
Thanks for the ping @sixhours! The spacing looks fine on my end! I'd like to cc @autumnfjeld on this one. We're getting ready to launch an onboarding experiment (if we haven't already) and wanted to give the new experiment some time without pushing any changes to make sure the data is tracking fine. Autumn, do you see any issues with merging this PR when it's ready? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is helpful discussion on the onboarding experiment This discussion p1736797862169599/1736797618.525879-slack-C085HCWCEDN shares which metrics the data team is watching, for example signup completions and cash sales. @isatuncman-auto Please wait a couple days to merge this. p1736803549963059/1736797618.525879-slack-C085HCWCEDN |
I suggest we close this, as this view is being phased out for an in-WordPress launchpad. However, I do think it's important to make launching more meaningful, so I've started #98860 to formulate a plan on how we can do this considering the revised path forward. |
Closes #76947
Proposed Changes
Adds
Your site is private and only visible to you. When you're ready, launch your site to make it public.
description on launchpad.This copy is already used on different areas and translation is ready to use.
Why are these changes being made?
Launching a site can sound too big of a change for a lot of customers. By adding context on what that change represents, we can make customers more confident, which should lead to an increase in launched sites.
Testing Instructions
Launch your site
button.Pre-merge Checklist