Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Refactor consolidated view styles for improved responsiveness #97750

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

andrii-lysenko
Copy link
Contributor

Related to pfunGA-4jr-p2#comment-7209

Proposed Changes

This PR changes mobile layout for consolidated-views component:

  • Change layout from row to column for better mobile display.
  • Introduce media queries to adjust styles for mobile and wide screens.
  • Update card styles to ensure full width on mobile and revert to two-column layout on larger screens.
Screenshot 2024-12-23 at 2 24 18 PM

Why are these changes being made?

Testing Instructions

  • Using live link below navigate to /referrals/dashboard
  • Using browser tools check different mobile screen sizes.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@andrii-lysenko andrii-lysenko added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. A4A labels Dec 23, 2024
@andrii-lysenko andrii-lysenko requested a review from a team December 23, 2024 22:36
@andrii-lysenko andrii-lysenko self-assigned this Dec 23, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug a4a/referral-cards-improve-mobile-ui on your sandbox.

Copy link
Contributor

@travisw travisw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@andrii-lysenko andrii-lysenko merged commit 7d556f3 into trunk Dec 26, 2024
13 checks passed
@andrii-lysenko andrii-lysenko deleted the a4a/referral-cards-improve-mobile-ui branch December 26, 2024 16:28
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants