Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: remove style variation badges from theme card #94512

Closed
wants to merge 1 commit into from

Conversation

vcanales
Copy link

Related to #93931

Proposed Changes

  • Remove Style Variation badges from Theme Cards.
  • Place the Theme Tier badge where the Style Variation badges were.

Why are these changes being made?

  • To simplify the visual layout of theme cards by removing the redundant style variation badges.
  • To address user feedback from #93799, which highlighted that multiple badges on theme cards were causing confusion and visual clutter.
  • By removing the style variation badges and keeping only the Theme Tier badge, the theme selection process becomes focused on key information (Theme Tier).
Before After
image image
Multiple badges displayed, including style variations, which caused visual clutter. Only the Theme Tier badge is displayed, simplifying the UI.

Testing Instructions

  • Verify that style variation badges have been removed from all theme cards.
  • Check that the Theme Tier badge now appears in place of the removed style variation badges.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~2174 bytes removed 📉 [gzipped])

name         parsed_size           gzip_size
themes           -2901 B  (-0.3%)    -1086 B  (-0.4%)
marketplace      -2901 B  (-0.3%)    -1088 B  (-0.4%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1086 bytes removed 📉 [gzipped])

name                                     parsed_size           gzip_size
async-load-signup-steps-theme-selection      -2901 B  (-0.8%)    -1086 B  (-0.9%)
async-load-design-blocks                     -2901 B  (-0.1%)    -1086 B  (-0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@vcanales vcanales marked this pull request as ready for review September 23, 2024 15:23
@vcanales vcanales requested a review from richtabor September 23, 2024 15:23
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 23, 2024
@vcanales vcanales closed this Oct 4, 2024
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants