Add self-hosted renovate #80193
Add self-hosted renovate #80193
Conversation
matticbot
added
the
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
See the new dashboard: #80201 |
There was a problem hiding this comment.
Moved this to json5 because comments are super helpful to have
| groupName: 'typescript-related packages', | ||
| matchPackagePatterns: [ 'typescript-eslint' ], | ||
| matchPackageNames: [ 'typescript' ], | ||
| prPriority: 2, |
There was a problem hiding this comment.
Question (non-blocking): Mostly out of curiosity, why don't we want @types packages included in the renovate update PRs? Have we had issues with them getting too far ahead?
There was a problem hiding this comment.
We do want @types to update! It just doesn't make sense to update them with Typescript -- they should be updated when the corresponding package is updated. For example, @types/react probably only needs to be updated when react is updated.
By the way, the config automatically updates everything by default when we don't specify a certain package (unless we manually ignore it). The groups we set up just add our own own settings on top of that, to help us be more organized.
|
Overall, this change looks good to me! 😄 I haven't done too much with renovate bot in the past, so I might be missing some context about some of the package update rules, and it might be good to have someone from frameworks double-check. Thanks for doing this, that's awesome that we'll get renovate running again! 🥳 |
noahtallen
force-pushed
the
try-renovate-github-actions
branch
from
8e06823 to
ca9e55f
Compare
Co-authored-by: Marin Atanasov <[email protected]>
Co-authored-by: Marin Atanasov <[email protected]>
|
Great suggestions; added! |
github-actions
bot
removed
the
[Status] Needs Review
Some time ago, Renovate was suspended at the organization level due to a security issue. While that was fixed, the account remains suspended. This PR proposes moving our config to "self-hosted" via GitHub actions, inspired by Jetpack. (Automattic/jetpack#23307)
I copy/pasted the config file from Jetpack (https://github.com/Automattic/jetpack/blob/trunk/.github/workflows/renovate.yml), and added the same RENOVATE_TOKEN secret to wp-calypso. (See pMz3w-eQ7-p2#comment-96792) I did make some small changes as well.
Testing:
Check github workflow run!