Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Assembler - Enable feature flag pattern-assembler/write-flow in Horizon #73089

Merged

Conversation

miksansegundo
Copy link
Contributor

Proposed Changes

  • Enable feature flag pattern-assembler/write-flow in the Horizon environment

This flag is already enabled for testing in wpcalypso env, but the issue with the LaunchPad Save modal is not reproducible there.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #72565

@miksansegundo miksansegundo requested a review from a team February 8, 2023 13:05
@miksansegundo miksansegundo self-assigned this Feb 8, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 8, 2023
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@autumnfjeld
Copy link
Contributor

Looks good to me! :) I'll update the CfT once you merge this. And then I'll test on horizon and we can see what's happening with the modal p1675847329299309/1675837107.374969-slack-CRWCHQGUB.

@miksansegundo miksansegundo merged commit 8a37238 into trunk Feb 9, 2023
@miksansegundo miksansegundo deleted the feat/pattern-assembler-write-flow-enable-horizon branch February 9, 2023 03:20
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants