Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Onboarding: Disable mshot design previews #49330

Closed
wants to merge 1 commit into from
Closed

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Jan 27, 2021

PR just in case we need to disable mShots.

Changes proposed in this Pull Request

Testing instructions

Turns off mshot design previews enabled in #49170, this reverts previews
back to calypso hosted screenshots.
@lsl lsl added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 27, 2021
@lsl lsl self-assigned this Jan 27, 2021
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Webpack Runtime (~43 bytes removed 📉 [gzipped])

name      parsed_size           gzip_size
manifest        -95 B  (-0.3%)      -43 B  (-0.3%)

Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded.

App Entrypoints (~80 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-main                  -398 B  (-0.0%)      -80 B  (-0.0%)
entry-login                 -105 B  (-0.0%)      -26 B  (-0.0%)
entry-gutenboarding         -105 B  (-0.0%)      -26 B  (-0.0%)
entry-domains-landing       -105 B  (-0.0%)      -26 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~3827 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
jetpack-connect          -255 B  (-0.0%)     -275 B  (-0.1%)
google-my-business       -183 B  (-0.1%)    -1027 B  (-1.1%)
marketing                +126 B  (+0.0%)     -614 B  (-0.4%)
plans                    -103 B  (-0.0%)      -17 B  (-0.0%)
devdocs                   +31 B  (+0.0%)       +4 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~44 bytes added 📈 [gzipped])

name                                            parsed_size           gzip_size
async-load-design-wordpress-components-gallery        +31 B  (+0.0%)      +44 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@lsl lsl closed this Jan 28, 2021
@lsl lsl deleted the update/disable-mshots branch January 28, 2021 23:34
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants