Fix/jest resolve module #47180
Merged
Fix/jest resolve module #47180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
scinos
force-pushed
the
fix/jest-resolve-module
branch
from
d9574cd to
032108f
Compare
matticbot
added
the
[Status] Needs Review
|
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D52363-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
tyxla
reviewed
Nov 6, 2020
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#47002 introduced a change where we don't compile
packages/as CJS by default. In those packages, in their package.json usuallymainpoints to a CJS compilation andmoduleto a ESM.This is fine when those packages are used in webpack, as it will read the file from
module. However Jest only looks formain, so the tests will fail to resolve those modules.Change
This PR changes our custom Jest resolver to look for
moduleand thenmainif the package comes frompackages/.Testing instructions
add/use-lp-in-calypso, and verify all tests pass when you runyarn test-client.