Have sync-newspack-blocks.sh fail if phpcbf does #44294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some discussion in slack with @noahtallen, this is a bit too forceful, at least for now, as the entire install will fail if It might make more sense if the failure was part of the build step rather than the install step, but for now I'm closing this PR. |
|
implemented the same functionality in #44323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
phpcbffailure within sync-newspack-blocks.sh so thatyarnand CI systems report it more loudlyTesting instructions
Check that the command fails if phpcbf is unavailable.
Fixes #