Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPT: Make cover block images fill entire block in SPT preview #39680

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

frontdevde
Copy link
Contributor

Changes proposed in this Pull Request

This PR aims to provide a pragmatic solution to the issue reported in #39351. With this PR in place, fixed background images on the cover block should fill the entire block in the SPT preview.

For further details please see this in-depth comment.

Testing instructions

  • Check out this PR locally and run npx lerna run dev --scope='@automattic/full-site-editing' --stream from Calypso root
  • Navigate to Pages > Add New to create a new page
  • In the page template selector, scroll down to Home Pages
  • Select the Rockfield page template (the one with cook's hands on it)
  • Verify that the result you see matches the After state below

Before:

rockfield-before

After:

rockfield-after

Fixes #39351

@frontdevde frontdevde requested a review from a team February 25, 2020 17:14
@frontdevde frontdevde self-assigned this Feb 25, 2020
@matticbot
Copy link
Contributor

Copy link
Member

@obenland obenland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I couldn't reproduce the original bug with my main machine, I was able to reproduce it with my other one. It's a bummer we can't have both, a full image and a working parallax effect.

I'm approving the technical fix here. Let's wait until @ianstewart had a chance to weigh in at #39351 (comment) before merging it, please.

@frontdevde
Copy link
Contributor Author

frontdevde commented Feb 26, 2020

Let's wait until @ianstewart had a chance to weigh in

I've just had the chance to briefly chat to Ian. He was just about to board a transatlantic flight and said that @alaczek is filling in for him while he's away. As she already gave her OK in this comment, I'll go ahead and merge this (especially given that it's a clear improvement over the current state as well).

@frontdevde frontdevde merged commit 616f365 into master Feb 26, 2020
@frontdevde frontdevde deleted the fix/spt-cover-block-fixed-background branch February 26, 2020 10:40
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layouts: Rockfield preview images not filling canvas
3 participants