FSE: Use older editor package for better Gutenberg compatibility.

[kwight]

Changes proposed in this Pull Request

Stick with the older editor package in case we need to accommodate older versions of Gutenberg. See #33720 (comment).

Testing instructions

• Add a Site Description block and verify it continues to work normally.

[matticbot]

Test live: https://calypso.live/?branch=update/fse-description-block-editor

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[gwwar]

For context the @wordpress/editor package was deprecated in favor of @wordpress/block-editor with no target date

Let's double check what get's included/or not in the dist files. Ideally we avoid sending down duplicate packages (or multiple versions) but depending on what happens we can adjust what we do for the deprecation strategy here.

[gwwar]

Okay so we're externalizing this using the wordpress-external-dependencies-plugin props @sirreal. We'll need to be careful then about keeping track of what versions we support (WP/Gutenberg), and when packages are fully dropped

wp-calypso/apps/full-site-editing/full-site-editing-plugin/full-site-editing/class-full-site-editing.php

Line 290 in a6b9d5e

plugin_dir_path( __FILE__ ) . 'dist/full-site-editing.deps.json'

https://333006-45936895-gh.circle-artifacts.com/0/tmp/artifacts/full-site-editing/full-site-editing-plugin/full-site-editing/dist/full-site-editing.deps.json

https://github.com/Automattic/wp-calypso/tree/master/packages/wordpress-external-dependencies-plugin

wp-calypso/packages/wordpress-external-dependencies-plugin/index.js

Line 101 in a6b9d5e

const depsFile = compilation.getPath( outputFilename.replace( /\.js$/i, '.deps.json' ), {

[gwwar]

Added a related writeup paAmJe-tx-p2

[gwwar]

Thanks @kwight ! I think this is good to ship if we can verify that no-one else has added back block-editor in the meantime.

[mmtr]

I think this is good to ship if we can verify that no-one else has added back block-editor in the meantime.

Actually, the dependency is currently duplicated:

wp-calypso/apps/full-site-editing/package.json

Lines 36 to 38 in 44c1687

	"@wordpress/block-editor": "^2.2.0",
	"@wordpress/blocks": "^6.2.3",
	"@wordpress/block-editor": "^2.0.3",

Seems that @rodrigoi also included it on #33885 for the InnerBlocks component, we can still import it from @wordpress/editor in order to support older versions of the plugin.

I'd suggest to update this PR too with a switch to the @wordpress/editor package on the a8c/post-content block, given that the change should be pretty straight forward.

[mmtr]

Note that I also included a small change fixing a typo in the site description block title (which I accidentally introduced in #33720).

Totally unrelated to what this PR is fixing, but didn't want to create a separate PR for such a small change.

[sirreal]

I left some thoughts on paAmJe-tx-p2#comment-1205 that may be interesting for folks to read.

[kwight]

Totally unrelated to what this PR is fixing, but didn't want to create a separate PR for such a small change.

There is no such thing as a PR that's too small 🙂(but yes, let's keep it in)

[kwight]

@gwwar @mmtr I've updated the post content block to use the deprecated package (and tested that the block still works). I think I've covered everything needed here to merge?

I'm a little confused by the app's package-lock.json, which continues to have references to @wordpress/block-editor, even after I did npm install and npm update for funsies in the directory – is there a proper way to update it that I can't find?

@sirreal I like your suggestion in that we don't have to worry about anything while writing code (just use the newest thing). But like you mentioned in that comment, it relies on the two packages having identical exports, correct? Maybe getting this in for now is smart until we can figure out if we need something more robust.

[sirreal]

But like you mentioned in that comment, it relies on the two packages having identical exports, correct?

Right, that was an assumption on my part that may or may not be accurate. I was under the impression that editor was essentially renamed to block-editor, but I'm not informed that is likely a poor assumption.

Please proceed with the immediate fix. My comment was intended to provide helpful information, I don't know whether it is actionable or how relevant it is for you right now.

[gwwar]

Ah can we gitignore the package-lock.json? We're using externals for @wordpress/* here so even the versions in package.json don't have much meaning.

[gwwar]

I was under the impression that editor was essentially renamed to block-editor

💯

[gwwar]

Thanks @kwight! Let's stick with this approach until we make the required webpack plugin changes.

I verified that the block name was updated:

And that we only have the following in full-site-editing.deps.json

[kwight]

Ah can we gitignore the package-lock.json?

Oh, no need, it's already ignored higher up somewhere; I was just trying to make sense of what I thought I should be seeing.

We're good to go then; had to rebase, will merge after tests clear again.